eileen authored 6 years ago and Kevin Cristiano committed 6 years ago

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

props @MegaphoneJon
The wp-cli-login-server plugin checks for the presence of elements in the $_GET array, and fails if any are found. This conflicts with CiviCRM, which places:

$_GET['civicrm_install_type'] = 'wordpress';

into every page load.

I confirmed that this value is only used for install, and placed a conditional around it to only insert pre-install. I successfully installed CiviCRM and engaged in normal use with the conditional applied, and confirmed that this fixed the WP plugin.

This is intended to close aaemnnosttv/wp-cli-login-command#24.

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Fixes https://lab.civicrm.org/dev/wordpress/issues/1



Plan for 5.2.0 release if not merged

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Update rctest.md to ntest https://lab.civicrm.org/dev/membership/issues/4 and https://github.com/civicrm/civicrm-core/pull/12178

Fixes https://lab.civicrm.org/dev/wordpress/issues/1



Plan for 5.2.0 release if not merged

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

https://github.com/civicrm/civicrm-core/pull/11936


Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

https://github.com/civicrm/civicrm-core/pull/11936


Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Fixes https://lab.civicrm.org/dev/wordpress/issues/1



Plan for 5.2.0 release if not merged

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

https://github.com/civicrm/civicrm-core/pull/11936


Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>

eileen authored 7 years ago and Kevin Cristiano committed 7 years ago

Signed-off-by: Kevin Cristiano <kcristiano@tadpole.cc>