Skip to content
Snippets Groups Projects
Verified Commit a5ce4e79 authored by Kevin Cristiano's avatar Kevin Cristiano :earth_americas:
Browse files

dev/core#1637 regression fix on WP urls #16713

PR @eileenmcnaughton https://github.com/civicrm/civicrm-core/pull/16713
Overview
Reverts a change in 5.23 that is causing url breakage on WP when clean urls are not enabled (https://lab.civicrm.org/dev/core/issues/1637) and possibly Joomla but
still checking that (https://lab.civicrm.org/dev/financial/issues/120)

Before
Generated url is
/wp-admin/admin.php/?page=CiviCRM&q=civicrm%2Fupgrade%2Fqueue%2Fajax%2FrunNext

After
Generated url is /wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fupgrade%2Fqueue%2Fajax%2FrunNext

Technical Details
Revert "Make $civicrm_paths less sensitive to trailing slashes. Add t…ests."

This is currently causing breakage on wordpress sites where clean urls are not enabled.

Compare the 2 urls below - the top one has an extra (breaking) slash added by this PR.

I propose a quick revert & patch release followed by 'the right' fix at a slower pace
/wp-admin/admin.php/?page=CiviCRM&q=civicrm%2Fupgrade%2Fqueue%2Fajax%2FrunNext
/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fupgrade%2Fqueue%2Fajax%2FrunNext

This reverts commit 232fdd3.

This is the relevant line https://github.com/civicrm/civicrm-core/pull/16404/files#diff-1544096e8e60bfe9fe73eeca2844804eR223
parent 8e5d8150
Branches
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment